Add signal exit-code option #131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change maintains backwards compatibility since the default value is still 1. Fix minio#130
|
This does the trick and will solve our use case as well. Thanks An enhancement could be to configure the exit code not globally but based on received signal. |
vadmeste
requested changes
Jun 13, 2025
| default: | ||
| console.Infof("caught signal '%s'\n", signal) | ||
| os.Exit(1) | ||
| os.Exit(globalExitCode) |
Member
There was a problem hiding this comment.
We are not so keen to add new flags. I think all what you need to do is to run os.Exit(143) when we receive syscall.SIGTERM. Kubernetes will understand that and will not flag an error for the container
Author
|
Hi Team, going to close as we implemented another solution to route our internal traffic to MinIO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change maintains backwards compatibility since the default value is still 1.
Fix #130
New Feature: Configurable Exit Code
globalExitCodeas an integer to store the configurable exit code. (main.go, main.goR86)--exit-codeflag to allow users to specify the exit code when the program terminates. The default value is set to1. (main.go, main.goR1386-R1390)globalExitCodefor program termination instead of a hardcoded value. (main.go, main.goL1245-R1247)globalExitCodeto the value provided by the--exit-codeflag during program initialization. (main.go, main.goR1079)